add deprecation notice to py2wasm #53
Conversation
karthik2804
commented
Feb 29, 2024
•
karthik2804
commented
Signed-off-by: karthik2804 <[email protected]>
There was a problem hiding this comment.
I am slightly wary of the unconditional "move to componentize-py". As I understand it, this works only for Spin 2.2 or above.
A possible alternative approach would be to release a new py2wasm package, with the same binaries as the current one, but marked with ">=2.2" compatibility, and put the deprecation warning on that. Then people who are able to use the new SDK would be advised to, and people who are not would not be given advice that would break them. Thoughts?
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "py2wasm", | |||
| "description": "A plugin to convert Python applications to Spin compatible modules", | |||
| "description": "A plugin to convert Python applications to Spin compatible modules. Note: This plugin has been deprecated in favour of the newer SDK based on componentize-py. To move to the last SDK, uninstall the plugin and visit https://developer.fermyon.com/spin/v2/python-components ", | |||
There was a problem hiding this comment.
| "description": "A plugin to convert Python applications to Spin compatible modules. Note: This plugin has been deprecated in favour of the newer SDK based on componentize-py. To move to the last SDK, uninstall the plugin and visit https://developer.fermyon.com/spin/v2/python-components ", | |
| "description": "A plugin to convert Python applications to Spin compatible modules. Note: This plugin has been deprecated in favour of the newer SDK based on componentize-py. To move to the latest SDK, uninstall the plugin and visit https://developer.fermyon.com/spin/v2/python-components.", |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "py2wasm", | |||
| "description": "A plugin to convert Python applications to Spin compatible modules", | |||
| "description": "A plugin to convert Python applications to Spin compatible modules. Note: This plugin has been deprecated in favour of the newer SDK based on componentize-py. To move to the last SDK, uninstall the plugin and visit https://developer.fermyon.com/spin/v2/python-components ", | |||
There was a problem hiding this comment.
Same typo fixes throughout. But really, is there much value in retrofitting to old versions? Is anyone going to install / update to these old versions at this point? The only scenario I can think of is if someone is on Spin 0.9 or whatever and the more recent version is incompatible, but those users won't be able to run componentize-py based components anyway will they?
|
Oh, I like the idea of bumping the version and Spin compat version. I will do that instead. |
So can we close this PR? |
|
We can close this PR. But now I'm curious while releasing a new version we want to update the binary itself to have a deprecation notice or is that too much? |
|
Seems reasonable to add a deprecation notice just so they know it's no longer being supported. We don't need to push them hard to upgrade, though -- if py2wasm works fine for them they can keep using it. |
